Fixed the install progress bar bug #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partik <[email protected]>
partik03
changed the title
|
@nyrahul Please review this pull request. |
|
Can we fix/merge this @daemon1024 ? |
|
@nyrahul we handled this as part of We don't have a progress bar anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the install progress bar bug
Linked Issue #393
Issue
The install progress earlier was exceeding 100% on some instances due to irregularities in the number of calls to functions
printMessage.Fix
Fixed the issue by initializing a global variable and incrementing its value on some instances to ensure the progress is under 100% all the time.